-
Notifications
You must be signed in to change notification settings - Fork 5
Update ui-events to 0.2.0. #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
This will stay up to date with ui-events main until 0.2.0 is released. :+ ) |
|
Is there a reason this is still a draft? Should I not merge it yet? |
a66c675 to
e4efa41
Compare
| self.state | ||
| .render_root | ||
| .handle_window_event(WindowEvent::RebuildAccessTree); | ||
| .handle_window_event(WindowEvent::EnableAccessTree); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to need somebody to confirm that this is the correct way to do this now, I wasn't involved in any of the changes that caused this.
I may end up splitting the Masonry upstream churn changes from this PR when it comes time to merge, just want to flag this for somebody to look at.
f266b8a to
5e123b8
Compare
5e123b8 to
6c2168f
Compare
0dea0e6 to
d6b6653
Compare
d6b6653 to
2488f6e
Compare
2488f6e to
22f951f
Compare
|
I've split out the masonry and other assorted updates into #13, and tried this again on a device. It all seems to be working now. |
No description provided.